Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(analytics): extend_session parameter #5973

Merged
merged 2 commits into from
Dec 31, 2021
Merged

fix(analytics): extend_session parameter #5973

merged 2 commits into from
Dec 31, 2021

Commits on Dec 29, 2021

  1. fix(analytics,android): cast extend_session value to long 

    Firebase requires a long value in Android for the extend_session parameter. See https://firebase.google.com/docs/reference/android/com/google/firebase/analytics/FirebaseAnalytics.Param#public-static-final-string-extend_session
    @phjudge
    phjudge committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    f4f9d16 View commit details
    Browse the repository at this point in the history

  2. fix(analytics,ios): cast extend_session value to @yES 

    Firebase in iOS expects an extend_session value of @yES. See https://firebase.google.com/docs/reference/ios/firebaseanalytics/api/reference/Constants#/c:FIRParameterNames.h@kFIRParameterExtendSession
    @phjudge
    phjudge committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    cdf83bf View commit details
    Browse the repository at this point in the history