Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(messaging): Document the 8 second delay introduced by the earlier mitigation to Issue 4144 #5545

Conversation

brianathere
Copy link
Contributor

Description

This change documents the 8 second delay in the delivery of background notifications so developers are aware of the minimum time it will take for a notification do make it to the application in a background state and not have to wonder why it's taking so long.

Related issues

4144

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • [X ] No

Test Plan

Documentation change


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Jul 24, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

react-native-firebase-next – ./website_modular

🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/EGxdLUXdqtoVg3Hc5FjsrNTLRhcC
✅ Preview: Canceled

react-native-firebase – ./

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/4BAFxdVxbTLjqh19UcBMJYWGjDuQ
✅ Preview: https://react-native-firebase-git-fork-heredotvideo-br-cae3aa-invertase.vercel.app

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Brian Meek seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you have a maybe-actually-works-around-the-issue PR separately, but this is a nice docs change for now, the delay can be unexpected, that has come up before, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants