fix(app, android): fix TaskExecutor ConcurrentModificationException #5230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Access to the collection of TaskExecutors wasn't correctly synchronized in all places Fixes #5225
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/invertase/react-native-firebase/9NUGhx73kXgUZREbzdkTtcJZcEyh |
Codecov Report
@@ Coverage Diff @@
## master #5230 +/- ##
=======================================
Coverage 88.86% 88.86%
=======================================
Files 109 109
Lines 3743 3743
Branches 360 360
=======================================
Hits 3326 3326
Misses 370 370
Partials 47 47 |
mikehardy
force-pushed
the
@mikehardy/issue5225-task-executor-cme
branch
from
18baba5
to
ef4759c
Compare
previously they were the ugliest, my fault
mikehardy
force-pushed
the
@mikehardy/issue5225-task-executor-cme
branch
from
824bea5
to
7d07d85
Compare
mikehardy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The new TaskExecutor code in #4981 is great but it is new and had a concurrency issue causing a redbox on CatalystInstance shutdown, which shows up as a redbox in dev when you reload the app
Related issues
Fixes #5225
Related #5233 - redbox detection was flaky and I don't want to delay this fix, split it to separate PR
Release Summary
Each commit is separate with a conventional commit message
Checklist
AndroidiOSe2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Redbox was reproducible in E2E suite after Detox reloaded the app, but the tests continued running under the redbox, so it passed CI. Fixed root cause of the initial bug and locally have redbox detection working but needs de-flaking
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter