Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app, android): fixes possible crash on first launch #4990

Merged
merged 1 commit into from
Mar 9, 2021
Merged

fix(app, android): fixes possible crash on first launch #4990

merged 1 commit into from
Mar 9, 2021

Conversation

JiboStore
Copy link
Contributor

@JiboStore JiboStore commented Mar 5, 2021

Description

Fix crash on first run on Android-11 when context.getExternalFilesDir(null); returns null

Related issues

Fixes #4979

Release Summary

PR title

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Mar 5, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/2AnipZUa6ifn4MpepL94D5wqzksb
✅ Preview: https://react-native-f-git-fork-jibostore-fix-react-native-fireb-464f7d.vercel.app

@CLAassistant
Copy link

CLAassistant commented Mar 5, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #4990 (820bb47) into master (0506703) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4990   +/-   ##
=======================================
  Coverage   88.99%   88.99%           
=======================================
  Files         109      109           
  Lines        3721     3721           
  Branches      348      348           
=======================================
  Hits         3311     3311           
  Misses        369      369           
  Partials       41       41           

@mikehardy mikehardy changed the title [fix] fix: fixes crash for Android 11 first launch fix(app, android): fixes possible crash on first launch Mar 5, 2021
@mikehardy mikehardy added the Workflow: Needs Review Pending feedback or review from a maintainer. label Mar 5, 2021
@mikehardy
Copy link
Collaborator

Hi @JiboStore - thank you for this!

Can you follow the information here to sign the CLA? We can't merge without that step #4990 (comment)

@mikehardy mikehardy added Blocked: Missing CLA Workflow: Pending Merge Waiting on CI or similar and removed Workflow: Needs Review Pending feedback or review from a maintainer. labels Mar 5, 2021
@mikehardy
Copy link
Collaborator

@JiboStore not to pester, I just know things get lost in all the notifications we all get. And you've done great work here, I'd like to merge it in but need the CLA signed - see above for instructions. Cheers!

@JiboStore
Copy link
Contributor Author

@mikehardy I have signed the CLA, on my side, it shows that Contributor License Agreement is signed. and all checkmarks are green. I wonder if there is some other steps I missed?

@mikehardy
Copy link
Collaborator

I think it was I who missed it! Everything does look green thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛] Bug Report Title - App crashed on first time launch with latest version [v10.8.1]
3 participants