fix: add analytics peerDependency to remote-config, dynamic-links, in-app-messaging

[mikehardy]

Description

Turns out that analytics is actually required for certain modules, or you get startup crashes - #4821

When analytics is optional the documents say so, like crashlytics

For an optimal experience with Firebase Crashlytics, we recommend enabling Google Analytics in your project by adding the Firebase pod for Analytics to your app as well

But for these ones it is not listed as optional, and a crash was observed

Dynamic Links

• iOS: https://firebase.google.com/docs/dynamic-links/ios/create#set-up-firebase-and-the-dynamic-links-sdk
• Android: https://firebase.google.com/docs/dynamic-links/android/create#set-up-firebase-and-the-dynamic-links-sdk

Remote Config

• iOS: https://firebase.google.com/docs/remote-config/use-config-ios

Note: When installing the iOS SDK, you have the option of adding the dependency for Analytics. Analytics is required for Remote Config's conditional targeting of app instances to user properties, audiences, and Firebase Predictions.

• Android https://firebase.google.com/docs/remote-config/use-config-android

For Remote Config, Google Analytics is required for the conditional targeting of app instances to user properties, audiences, and Firebase Predictions. Make sure that you enable Google Analytics in your project.

In App Messaging

• iOS: https://firebase.google.com/docs/in-app-messaging/get-started?platform=ios#add_the_sdk_to_your_project
• Android: https://firebase.google.com/docs/in-app-messaging/get-started?platform=android#add_the_sdk_to_your_project

Related issues

Fixes #4821

Release Summary

This should be rebase merged so that each module get its own changelog entry, in my opinion, otherwise I'd use:

fix(dependencies): add required analytics peerDependency to in-app-messaging, remote-config, dynamic-links

Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • Yes
• My change supports the following platforms;
  • Android
  • iOS
• My change includes tests;
  • e2e tests added or updated in packages/\*\*/e2e
  • jest tests added or updated in packages/\*\*/__tests__
• I have updated TypeScript types that are affected by my change.
• This is a breaking change;
  • Yes
  • No - the dependency was actually always needed, this is just a fix to add it

Test Plan

---

Think react-native-firebase is great? Please consider supporting the project with any of the below:

• 👉 Star this repo on GitHub ⭐️
• 👉 Follow React Native Firebase and Invertase on Twitter

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/dmahqx0b9
✅ Preview: https://react-native-firebase-git-mikehardy-package-peerdeps.invertase.vercel.app

[codecov]

Codecov Report

Merging #4850 (7f186a6) into master (51edf96) will increase coverage by 0.44%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4850      +/-   ##
==========================================
+ Coverage   88.66%   89.09%   +0.44%     
==========================================
  Files         109      109              
  Lines        3712     3712              
  Branches      347      347              
==========================================
+ Hits         3291     3307      +16     
+ Misses        379      363      -16     
  Partials       42       42              

[mikehardy]

I've asked for review (always helps!) but default stance is to merge and release in a couple days in absence of review

[nfcampos]

@mikehardy for dynamic links the docs appear to say it is optional, see here
https://firebase.google.com/docs/ios/setup#available-pods
https://firebase.google.com/docs/ios/app-store-data-collection#dynamic-links

[mikehardy]

Yeah, I was a bit iffy on that one - thanks for providing deeper information - you'll note from my link in the PR that no optionality is mentioned (https://firebase.google.com/docs/dynamic-links/ios/create#set-up-firebase-and-the-dynamic-links-sdk) - makes it hard to reason about! Also there may be platform differences between ios and android - hopefully not as I am not sure how I would express that when the peerDependency is for both.

At any rate, based on your documentation I will remove the peer dependency on analytics from dynamic links

[nfcampos]

Yeah the documentation is a bit of a maze