Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admob, android): add adaptive banner support #4840

Merged
merged 5 commits into from
Jan 29, 2021

Conversation

melkayam92
Copy link
Contributor

Description

This pull request adds support for adaptive banners in Android.

Release Summary

Added adaptive banner support for Android.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

@vercel
Copy link

vercel bot commented Jan 29, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/grmdbv9u8
✅ Preview: https://react-native-firebase-git-fork-melkayam92-master.invertase.vercel.app

@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #4840 (a19967f) into master (20a05cd) will increase coverage by 3.61%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4840      +/-   ##
==========================================
+ Coverage   85.48%   89.09%   +3.61%     
==========================================
  Files         109      109              
  Lines        3712     3712              
  Branches      347      347              
==========================================
+ Hits         3173     3307     +134     
+ Misses        473      363     -110     
+ Partials       66       42      -24     

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM like before (it was already reviewed as you know) but know with the CLA signed 🏆 😆

Thanks for working through that @melkayam92 and contributing this

@mikehardy mikehardy merged commit 51edf96 into invertase:master Jan 29, 2021
@mikehardy
Copy link
Collaborator

@melkayam92 10.6.1 is out with this change! Thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants