Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: undelivered background data message ios #4144

Merged
merged 1 commit into from
Aug 26, 2020
Merged

fix: undelivered background data message ios #4144

merged 1 commit into from
Aug 26, 2020

Commits on Aug 26, 2020

  1. Temp fix: undelivered background data message ios 

    This should be viewed as a temporary fix.
A lot of people are reporting that the background data messages on iOS are not being delivered. The app wakes up, but the background listener doesn’t receive the message. Some apps that have a lot of JS apparently need more than the 2s timeout to be ready. So what happens is - app is started, 2s elapse, RNFBMessaging sends the message to the js handler, but the JS handler is not ready yet and misses the message. We mitigate this by delaying the delivery of the message to the JS side.

This solution however is not optimal becasue we are sending a completionHandler after about 25s which means that our JS code would have only 16 to do something with the data message.

A correct fix would be to figure out how to dispatch the message once the JS side is actually ready.

invertase#4104
    @compojoom
    compojoom committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    d29531c View commit details
    Browse the repository at this point in the history