-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: retry all soft-fail Android E2E steps, add logging to iOS E2E #4084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is quite large and managing emulator internal space is important
…s to 29 Includes output of `./gradlew wrapper` to regenerate everything
Upstream bug resolved
This should speed things up a bit, increasing success rate vs timeouts
Should help diagnose iOS flakiness there
It is the default on macOS 10.15 runner, so special setup unnecessary
This is the default, so special configuration not needed, but still need to extract the Xcode version for Detox build cache
Follow-on ideas are to make it a matrix so multiple device APIs are handled
|
Salakar
approved these changes
Aug 14, 2020
LGTM! :) Changes make sense |
Salakar
changed the title
Retry all soft-fail Android E2E steps, add logging to iOS E2E
chore: retry all soft-fail Android E2E steps, add logging to iOS E2E
Aug 14, 2020
Great! I'll merge it then and start accumulating false-negative data with this then The "step chaining / outcome aggregation" trick is ugly to my eyes but it's the github-recommended way at the moment and dang if it doesn't work.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A bit more de-flaking, I think this will handle everything remaining seen on the Android side
Added iOS logging but haven't attempted anything there - not sure what the failure modes are yet
The commits are all small separate changes and bear useful titles, they should be reviewed one at a time
Related issues
FIxes #4058
Release Summary
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter