-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(template): add Firebase configure to AppDelegate.m #3029
Conversation
if not this code block, Application rebuilds every time it goes to background
Codecov Report
@@ Coverage Diff @@
## master #3029 +/- ##
=======================================
Coverage 89.83% 89.83%
=======================================
Files 109 109
Lines 3381 3381
=======================================
Hits 3037 3037
Misses 344 344 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Salakar this seems like it matches my memory of the documentation for brownfield projects, is it an oversight in the template?
If I recall correctly, the main reason its not there by default is that iOS will crash if you don't yet have a GoogleService plist file added and then try to init Firebase via this configure method. Plist file is not required for JS side initialised Firebase apps. Would need to confirm the crash still occurs or not before merging this I think |
|
As @Salakar said, this still crashes the app unfortunately. |
Closing this as we're not actively maintaining the template anymore as integrating RNFB into existing projects is fairly minimal now so the template doesn't do much in the way of time saving. |
if not this code block, Application rebuilds every time it goes to background
Summary
Checklist
Android
iOS
e2e
tests added or updated in packages/**/e2eTest Plan
Release Plan
[CATEGORY][type] [LOCATION] - Message
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter