Add enableCrashlyticsCollection to Crashlytics #1718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI reported |
Salakar
previously approved these changes
Dec 1, 2018
increment yarn caching version - eslint bug
Codecov Report
@@ Coverage Diff @@
## master #1718 +/- ##
==========================================
+ Coverage 76.1% 76.16% +0.06%
==========================================
Files 72 72
Lines 1837 1838 +1
==========================================
+ Hits 1398 1400 +2
+ Misses 439 438 -1 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1718 +/- ##
==========================================
+ Coverage 76.1% 76.16% +0.06%
==========================================
Files 72 72
Lines 1837 1838 +1
==========================================
+ Hits 1398 1400 +2
+ Misses 439 438 -1 |
|
Thanks for this @timwangdev - looks great. Looks like the eslint issue is something to do with yarn caching on the ci, I've just pushed a commit on your branch to increment the cache version to wipe it, should be ok now - we'll see 👍
|
Salakar
added
plugin: crashlytics
Salakar
previously approved these changes
Dec 1, 2018
Salakar
pushed a commit
to invertase/react-native-firebase-docs
that referenced
this pull request
Dec 1, 2018
|
Well, I can't get the CI to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow developer to manually initialize Crashlytics when disabled automatic initialization as described here. If the the module has already been initialized, this method should be a no-op according to Fabric docs.
This would be useful in cases like GDPR.
Checklist
AndroidiOSe2etests added or updated in /tests/e2e/*Test Plan
Pass e2e test.
Release Plan
[IOS] [ANDROID] [FEATURE] [CRASHLYTICS] - Add enableCrashlyticsCollection to Crashlytics
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter