Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Firebase.auth.User.updateProfile cash with null values #911

Closed
aMarCruz opened this issue Mar 26, 2018 · 1 comment
Closed

BUG: Firebase.auth.User.updateProfile cash with null values #911

aMarCruz opened this issue Mar 26, 2018 · 1 comment
Labels
impact: web-implementation An API in RNFB does not conform to the Firebase Web SDK platform: android platform: ios plugin: authentication Firebase Authentication type: bug New bug report

Comments

@aMarCruz
Copy link
Contributor

Issue

From the Google updateProfile sample:

// Passing a null value will delete the current attribute's value, but not
// passing a property won't change the current attribute's value:
// Let's say we're using the same user than before, after the update.

react-native-firebase will crash with this:

const user = firebase.auth().currentUser
if (user && user.photoURL) {
    user.updateProfile({ photoURL: null })
}

This is in RNFirebaseAuth.java when trying Uri.parse:

image

Environment

  1. Application Target Platform:

Device: Android 7.0 (Samsung S7 Edge)
targetSdk 26

  1. Development Operating System:

Linux Mint 18.3
VS Code v1.21.1

  1. Build Tools: 27.0.3

  2. React Native version: 0.53.3

  3. RNFirebase Version: 3.3.1

  4. Firebase Module: Auth

Thanks in advance!

BTW: I ❤️ RNF

@Salakar Salakar added type: bug New bug report platform: android platform: ios plugin: authentication Firebase Authentication impact: web-implementation An API in RNFB does not conform to the Firebase Web SDK labels Mar 26, 2018
@Salakar Salakar added this to the v4.0.0 Release milestone Mar 26, 2018
@chrisbianca
Copy link
Contributor

chrisbianca commented Mar 27, 2018

This has been fixed in 9f9a3da which will be incorporated into the next v4 release.

Thank you for such a detailed issue description!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact: web-implementation An API in RNFB does not conform to the Firebase Web SDK platform: android platform: ios plugin: authentication Firebase Authentication type: bug New bug report
Projects
None yet
Development

No branches or pull requests

3 participants