Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

problem with null values on logEvent only on Android #846

Closed
sibelius opened this issue Feb 23, 2018 · 1 comment
Closed

problem with null values on logEvent only on Android #846

sibelius opened this issue Feb 23, 2018 · 1 comment
Assignees
@Salakar
Labels
plugin: analytics Google Analytics for Firebase
Milestone
v3.3.0 Release

Comments

@sibelius
Copy link
Contributor

When I pass a null value, it breaks analytics on Android, but it works fine on iOS.

How can we improve this?

image
@Ehesp
Copy link
Member

Ehesp commented Feb 23, 2018

I guess you shouldn't be able to pass a null value in, since it should be an event name. Needs to be handled more gracefully though.

@Salakar Salakar self-assigned this Feb 23, 2018
@Salakar Salakar added the plugin: analytics Google Analytics for Firebase label Feb 23, 2018
@Salakar Salakar added this to the v3.3.0 Release milestone Feb 23, 2018
@Salakar Salakar closed this as completed in d1e86f5 Mar 5, 2018
Salakar added a commit that referenced this issue Mar 5, 2018
@Salakar
[tests][js][analytics] logEvent now validates argument types (fixes #846
e327174 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Salakar Salakar

Labels
plugin: analytics Google Analytics for Firebase
Projects
None yet
Milestone
v3.3.0 Release
Development

No branches or pull requests
3 participants
@Ehesp @sibelius @Salakar