Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth,android): Pass firebaseAuth into OAuthProvider.newBuilder(...) #7677

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

lanpai
Copy link
Contributor

@lanpai lanpai commented Mar 11, 2024

Description

The signInWithProvider, linkWithProvider, and reauthenticateWithProvider calls break when attempting to use a second firebase project since it initializes the provider using the default project while signing in with the secondary project.

Note: this already works correctly on iOS

Related issues

Release Summary

Fixed the signInWithProvider, linkWithProvider, and reauthenticateWithProvider implementations when using multiple Firebase projects

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

Checked the network logs before and after this change to confirm that the library is sending the correct project configuration.


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented Mar 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2024 6:10pm

@CLAassistant
Copy link

CLAassistant commented Mar 11, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

@github-actions github-actions bot added the Stale label Apr 10, 2024
@lanpai
Copy link
Contributor Author

lanpai commented Apr 11, 2024

bump so pr isn't auto-closed
@mikehardy wasn't sure who to ping here 🙏

@github-actions github-actions bot removed the Stale label Apr 11, 2024
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay! This looks like the correct+complete change for the OAuthProvider, yes!

Passes tests locally (rebased to current main, even), hopefully CI agrees

@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Apr 11, 2024
@mikehardy mikehardy merged commit 21a9454 into invertase:main Apr 11, 2024
13 of 15 checks passed
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants