Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth, android): add forceRecaptchaFlowForTesting API #7148

Merged
merged 2 commits into from
Jun 5, 2023

Conversation

billykwok
Copy link
Contributor

Description

Add support for the Android-only forceRecaptchaFlowForTesting method.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented May 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ❌ Failed (Inspect) Jun 5, 2023 4:22pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
react-native-firebase-next ⬜️ Ignored (Inspect) Jun 5, 2023 4:22pm

@CLAassistant
Copy link

CLAassistant commented May 30, 2023

CLA assistant check
All committers have signed the CLA.

mikehardy
mikehardy previously approved these changes Jun 5, 2023
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! This is a great change, and the attention to detail in the PR is excellent - much appreciated

@mikehardy mikehardy changed the title feat: support forceRecaptchaFlowForTesting on Android feat(auth, android): add forceRecaptchaFlowForTesting API Jun 5, 2023
@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Jun 5, 2023
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there were some completely trivial lint-type errors exposed by CI once I approved the CI runs, I just pushed a commit that cleans them all up, so it's ✨ clean, should go green now, will merge assuming yes / will fixup a touch more until it is green otherwise

@mikehardy
Copy link
Collaborator

The vercel deployment failure is not reproduced on other branches, going to ignore that here for the sake of merge and cleanup post-merge if it fails to deploy

@mikehardy mikehardy merged commit 95d014c into invertase:main Jun 5, 2023
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Jun 5, 2023
exaby73 pushed a commit that referenced this pull request Jul 25, 2023
Co-authored-by: Mike Hardy <github@mikehardy.net>
exaby73 pushed a commit that referenced this pull request Aug 8, 2023
Co-authored-by: Mike Hardy <github@mikehardy.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants