-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: *merge* setting to true irrespective of value passed #6436
fix: *merge* setting to true irrespective of value passed #6436
Conversation
*merge* option is being set to true, even if false is passed! This can result in unexpected results!
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh my, that's a laughably obvious issue, really sorry that crept in the library. Thanks so much for posting a patch.
Have you tried this (via patch-package patch or similar) in production and it's working for you?
Haven't tried it using any library but tested it once by directly changing the library code! |
Codecov Report
@@ Coverage Diff @@
## main #6436 +/- ##
=======================================
Coverage 25.83% 25.83%
=======================================
Files 97 97
Lines 4291 4291
Branches 1048 1048
=======================================
Hits 1108 1108
Misses 2583 2583
Partials 600 600 |
Description
merge option is being set to true, even if false is passed! This can result in unexpected results!
As per documentations, SetOptions merge can be one of "undefined", "true" or "false". But in the current implementation the false(boolean) value is mistreated as true only!
Fixed the SetOptions merge to handle false value.
Checklist
Android
iOS