Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firebase Performance error log on IOS #593

Closed
ghost opened this issue Nov 7, 2017 · 1 comment
Closed

Firebase Performance error log on IOS #593

ghost opened this issue Nov 7, 2017 · 1 comment
Assignees
Labels
plugin: performance Firebase Performance Monitoring type: bug New bug report

Comments

@ghost
Copy link

ghost commented Nov 7, 2017

Issue

When using firebase-perf to create/start/stop a trace the error log entry keeps being output on IOS.

Failed to start trace checkTone because it has already been started and stopped

I tracked the problem down to RNFirebasePerformance.m

- (FIRTrace *)getOrCreateTrace:(NSString *)identifier {
    if (_traces[identifier]) {
        return _traces[identifier];
    }
    FIRTrace *trace = [FIRPerformance startTraceWithName:identifier];
    _traces[identifier] = trace;
    return trace;
}

which is calling startTraceWithName instead of just traceWithName

Environment

  1. Application Target Platform: IOS
  1. Development Operating System: macOS Sierra
  1. Build Tools: XCode 9.1
  1. React Native version: 0.50.1
  1. RNFirebase Version: 3.1.0
  1. Firebase Module: FirebasePerformance (1.0.6)
Salakar added a commit that referenced this issue Nov 8, 2017
@Salakar
Copy link
Member

Salakar commented Nov 8, 2017

@peterdivvito thanks for flagging, have just pushed up a fix for this, will get this in the next patch release - most likely later today.

@Salakar Salakar closed this as completed Nov 8, 2017
@Salakar Salakar self-assigned this Nov 8, 2017
@Salakar Salakar added type: bug New bug report plugin: performance Firebase Performance Monitoring labels Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: performance Firebase Performance Monitoring type: bug New bug report
Projects
None yet
Development

No branches or pull requests

1 participant