[notifications][android] Fix incorrect array to arraylist cast #949

invertase · Apr 10, 2018 · eb91523 · eb91523
1 parent 5127486
commit eb91523
Showing 1 changed file with 3 additions and 21 deletions.
diff --git a/android/src/main/java/io/invertase/firebase/notifications/RNFirebaseNotificationManager.java b/android/src/main/java/io/invertase/firebase/notifications/RNFirebaseNotificationManager.java
@@ -17,7 +17,6 @@
 import android.net.Uri;
 import android.os.Build;
 import android.os.Bundle;
-import android.os.Parcelable;
 import android.support.v4.app.NotificationCompat;
 import android.support.v4.app.RemoteInput;
 import android.support.v4.content.LocalBroadcastManager;
@@ -341,7 +340,7 @@ private void displayNotification(Bundle notification, Promise promise) {
         nb = nb.setOngoing(android.getBoolean("onlyAlertOnce"));
       }
       if (android.containsKey("people")) {
-        String[] people = android.getStringArray("people");
+        List<String> people = android.getStringArrayList("people");
         if (people != null) {
           for (String person : people) {
             nb = nb.addPerson(person);
@@ -416,24 +415,6 @@ private void displayNotification(Bundle notification, Promise promise) {
         nb = nb.setWhen(when.longValue());
       }
 
-      // TODO: Big text / Big picture
-      /* String bigText = bundle.getString("big_text");
-      if(bigText != null){
-        notification.setStyle(new NotificationCompat.BigTextStyle().bigText(bigText));
-      }
-      String picture = bundle.getString("picture");
-      if(picture!=null){
-        NotificationCompat.BigPictureStyle bigPicture = new NotificationCompat.BigPictureStyle();
-
-        Bitmap pictureBitmap = getBitmap(picture);
-        if (pictureBitmap != null) {
-          bigPicture.bigPicture(pictureBitmap);
-        }
-        bigPicture.setBigContentTitle(title);
-        bigPicture.setSummaryText(bundle.getString("body"));
-
-        notification.setStyle(bigPicture);
-      } */
       // Build any actions
       if (android.containsKey("actions")) {
         List<Bundle> actions = (List) android.getSerializable("actions");
@@ -522,7 +503,8 @@ private RemoteInput createRemoteInput(Bundle remoteInput) {
       rb.setAllowFreeFormInput(remoteInput.getBoolean("allowFreeFormInput"));
     }
     if (remoteInput.containsKey("choices")) {
-      rb.setChoices(remoteInput.getStringArray("choices"));
+      List<String> choices = remoteInput.getStringArrayList("choices");
+      rb.setChoices(choices.toArray(new String[choices.size()]));
     }
     if (remoteInput.containsKey("label")) {
       rb.setLabel(remoteInput.getString("label"));