Skip to content

Commit

Permalink
test(ios): use concrete value of iOS for simulator device
Browse files Browse the repository at this point in the history
apparently the new version of macos-13 runner published for hosted
github actions defaults to iOS 17 simulators, which are troublesome

may fix our current iOS e2e workflow failures

ref actions/runner-images/issues 8023#issuecomment-1662478605
  • Loading branch information
mikehardy committed Aug 21, 2023
1 parent 19849de commit cc2d642
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions tests/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,15 +62,17 @@
"build": "set -o pipefail && xcodebuild VALID_ARCHS=\"`uname -m`\" CC=clang CPLUSPLUS=clang++ LD=clang LDPLUSPLUS=clang++ -workspace ios/testing.xcworkspace -scheme testing -configuration Debug -sdk iphonesimulator -derivedDataPath ios/build | xcbeautify",
"type": "ios.simulator",
"device": {
"type": "iPhone 14"
"type": "iPhone 14",
"os": "iOS 16.4"
}
},
"ios.sim.release": {
"binaryPath": "ios/build/Build/Products/Release-iphonesimulator/testing.app",
"build": "export RCT_NO_LAUNCH_PACKAGER=true && set -o pipefail | xcodebuild CC=clang CPLUSPLUS=clang++ LD=clang LDPLUSPLUS=clang++ -workspace ios/testing.xcworkspace -scheme testing -configuration Release -sdk iphonesimulator -derivedDataPath ios/build | xcbeautify",
"type": "ios.simulator",
"device": {
"type": "iPhone 14"
"type": "iPhone 14",
"os": "iOS 16.4"
}
},
"android.emu.debug": {
Expand Down

1 comment on commit cc2d642

@vercel
Copy link

@vercel vercel bot commented on cc2d642 Aug 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.