Skip to content

Commit

Permalink
fix(ios, expo): add Expo plugin objcpp / Expo 45 compatibility (#6223)
Browse files Browse the repository at this point in the history
  • Loading branch information
kbrandwijk authored Apr 28, 2022
1 parent 0fd4b4f commit 9de82d3
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ exports[`Config Plugin iOS Tests tests changes made to AppDelegate.m (SDK 43) 1`
// creating a bare React Native app (without Expo)
#import \\"AppDelegate.h\\"
@import Firebase;
#import <Firebase/Firebase.h>
#import <React/RCTBridge.h>
#import <React/RCTBundleURLProvider.h>
Expand Down Expand Up @@ -99,7 +99,7 @@ exports[`Config Plugin iOS Tests tests changes made to AppDelegate.m with Expo R
// It has the RCTBridge to be created by Expo ReactDelegate
#import \\"AppDelegate.h\\"
@import Firebase;
#import <Firebase/Firebase.h>
#import <React/RCTBridge.h>
#import <React/RCTBundleURLProvider.h>
Expand Down Expand Up @@ -189,7 +189,7 @@ exports[`Config Plugin iOS Tests tests changes made to AppDelegate.m with fallba
// some parts omitted to be short
#import \\"AppDelegate.h\\"
@import Firebase;
#import <Firebase/Firebase.h>
#import <React/RCTBridge.h>
#import <React/RCTBundleURLProvider.h>
Expand Down Expand Up @@ -240,7 +240,7 @@ exports[`Config Plugin iOS Tests tests changes made to old AppDelegate.m (SDK 42
// It expects the old react-native-unimodules architecture (UM* prefix)
#import \\"AppDelegate.h\\"
@import Firebase;
#import <Firebase/Firebase.h>
#import <React/RCTBridge.h>
#import <React/RCTBundleURLProvider.h>
Expand Down Expand Up @@ -351,7 +351,7 @@ exports[`Config Plugin iOS Tests works with AppDelegate.mm (RN 0.68+) 1`] = `
// using React Native 0.68 and is written in Objective-C++
#import \\"AppDelegate.h\\"
@import Firebase;
#import <Firebase/Firebase.h>
#import <React/RCTBridge.h>
#import <React/RCTBundleURLProvider.h>
Expand Down
2 changes: 1 addition & 1 deletion packages/app/plugin/src/ios/appDelegate.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export function modifyObjcAppDelegate(contents: string): string {
contents = contents.replace(
/#import "AppDelegate.h"/g,
`#import "AppDelegate.h"
@import Firebase;`,
#import <Firebase/Firebase.h>`,
);
}

Expand Down

1 comment on commit 9de82d3

@vercel
Copy link

@vercel vercel bot commented on 9de82d3 Apr 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.