Skip to content

Commit

Permalink
fix(crashlytics, ios): register library with dynamic version string
Browse files Browse the repository at this point in the history
internal registration of version should not use a hard-coded version string
as we will forget to update it (which we had done...) - use the shared / dynamic
version string
  • Loading branch information
mikehardy committed Apr 16, 2021
1 parent 4c640ff commit 90bceb2
Showing 1 changed file with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
#import "RNFBPreferences.h"
#import "RNFBJSON.h"
#import "RNFBMeta.h"
#import "RNFBApp/RNFBSharedUtils.h"
#import "RNFBVersion.h"
#import "RNFBSharedUtils.h"

NSString *const KEY_CRASHLYTICS_DEBUG_ENABLED = @"crashlytics_debug_enabled";
NSString *const KEY_CRASHLYTICS_AUTO_COLLECTION_ENABLED = @"crashlytics_auto_collection_enabled";
Expand All @@ -31,7 +32,7 @@
@implementation RNFBCrashlyticsInitProvider

+ (void)load {
[FIRApp registerInternalLibrary:self withName:@"react-native-firebase-crashlytics" withVersion:@"11.3.0"];
[FIRApp registerInternalLibrary:self withName:@"react-native-firebase-crashlytics" withVersion:RNFBVersionString];
}

+ (BOOL)isCrashlyticsCollectionEnabled {
Expand Down

1 comment on commit 90bceb2

@vercel
Copy link

@vercel vercel bot commented on 90bceb2 Apr 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.