Skip to content

Commit

Permalink
fix(app, ios): failing to resolve ios sdk from package.json is an error
Browse files Browse the repository at this point in the history
there should not be a fallback version here, as that behavior is untested, and
the package.json file must be resolved in general
  • Loading branch information
mikehardy committed Feb 25, 2021
1 parent ee9d0e4 commit 29d797d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/app/RNFBApp.podspec
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
require 'json'
require './firebase_json'
package = JSON.parse(File.read(File.join(__dir__, 'package.json')))
firebase_sdk_version = package['sdkVersions']['ios']['firebase'] || '~> 7.1.0'
firebase_sdk_version = package['sdkVersions']['ios']['firebase']

Pod::Spec.new do |s|
s.name = "RNFBApp"
Expand Down

0 comments on commit 29d797d

Please sign in to comment.