Skip to content

Commit

Permalink
fix(firestore, types): string is also correct type for orderBy (#7570)
Browse files Browse the repository at this point in the history
  • Loading branch information
ChromeQ authored Jan 23, 2024
1 parent 55c1c2c commit 1ea166a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/firestore/lib/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1288,7 +1288,7 @@ export namespace FirebaseFirestoreTypes {
* @param fieldPath The field to sort by. Either a string or FieldPath instance.
* @param directionStr Optional direction to sort by (`asc` or `desc`). If not specified, order will be ascending.
*/
orderBy(fieldPath: keyof T | FieldPath, directionStr?: 'asc' | 'desc'): Query<T>;
orderBy(fieldPath: keyof T | string | FieldPath, directionStr?: 'asc' | 'desc'): Query<T>;

/**
* Creates and returns a new Query that starts after the provided document (exclusive). The start
Expand Down

1 comment on commit 1ea166a

@vercel
Copy link

@vercel vercel bot commented on 1ea166a Jan 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.