-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
perf: increase task throughput in Android using thread pool executor (#…
…4981) * implement thread pool executor service * add getTransactionalExecutor method * use transactional executor during write action * transactional executor with identifier * execute database event in serial * execute firestore event in serial * absctract task excutor * do not re-excute rejected task while shutdown * add documentation * tests configuration * disable identified executor when maximum pool size is zero * update document * Avoid race condition in executors
- Loading branch information
1 parent
eeeba2e
commit 0e4e331
Showing
13 changed files
with
207 additions
and
47 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
121 changes: 121 additions & 0 deletions
121
packages/app/android/src/main/java/io/invertase/firebase/common/TaskExecutorService.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,121 @@ | ||
| package io.invertase.firebase.common; | ||
|
|
||
| /* | ||
| * Copyright (c) 2016-present Invertase Limited & Contributors | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this library except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * | ||
| */ | ||
|
|
||
| import io.invertase.firebase.common.ReactNativeFirebaseJSON; | ||
|
|
||
| import java.util.HashMap; | ||
| import java.util.Map; | ||
| import java.util.Set; | ||
| import java.util.concurrent.ExecutorService; | ||
| import java.util.concurrent.Executors; | ||
| import java.util.concurrent.RejectedExecutionHandler; | ||
| import java.util.concurrent.ThreadPoolExecutor; | ||
| import java.util.concurrent.TimeUnit; | ||
| import java.util.concurrent.SynchronousQueue; | ||
|
|
||
| public class TaskExecutorService { | ||
| private static final String MAXIMUM_POOL_SIZE_KEY = "android_task_executor_maximum_pool_size"; | ||
| private static final String KEEP_ALIVE_SECONDS_KEY = "android_task_executor_keep_alive_seconds"; | ||
|
|
||
| private final String name; | ||
| private final int maximumPoolSize; | ||
| private final int keepAliveSeconds; | ||
| private static Map<String, ExecutorService> executors = new HashMap<>(); | ||
|
|
||
| TaskExecutorService(String name) { | ||
| this.name = name; | ||
| ReactNativeFirebaseJSON json = ReactNativeFirebaseJSON.getSharedInstance(); | ||
| this.maximumPoolSize = json.getIntValue(MAXIMUM_POOL_SIZE_KEY, 1); | ||
| this.keepAliveSeconds = json.getIntValue(KEEP_ALIVE_SECONDS_KEY, 3); | ||
| } | ||
|
|
||
| public ExecutorService getExecutor() { | ||
| boolean isTransactional = maximumPoolSize <= 1; | ||
| return getExecutor(isTransactional, ""); | ||
| } | ||
|
|
||
| public ExecutorService getTransactionalExecutor() { | ||
| return getExecutor(true, ""); | ||
| } | ||
|
|
||
| public ExecutorService getTransactionalExecutor(String identifier) { | ||
| String executorIdentifier = maximumPoolSize != 0 ? identifier : ""; | ||
| return getExecutor(true, executorIdentifier); | ||
| } | ||
|
|
||
| public ExecutorService getExecutor(boolean isTransactional, String identifier) { | ||
| String executorName = getExecutorName(isTransactional, identifier); | ||
| synchronized(executors) { | ||
| ExecutorService existingExecutor = executors.get(executorName); | ||
| if (existingExecutor == null) { | ||
| ExecutorService newExecutor = getNewExecutor(isTransactional); | ||
| executors.put(executorName, newExecutor); | ||
| return newExecutor; | ||
| } | ||
| return existingExecutor; | ||
| } | ||
| } | ||
|
|
||
| private ExecutorService getNewExecutor(boolean isTransactional) { | ||
| if (isTransactional == true) { | ||
| return Executors.newSingleThreadExecutor(); | ||
| } else { | ||
| ThreadPoolExecutor threadPoolExecutor = new ThreadPoolExecutor(0, maximumPoolSize, keepAliveSeconds, TimeUnit.SECONDS, new SynchronousQueue<Runnable>()); | ||
| threadPoolExecutor.setRejectedExecutionHandler(executeInFallback); | ||
| return threadPoolExecutor; | ||
| } | ||
| } | ||
|
|
||
| private RejectedExecutionHandler executeInFallback = new RejectedExecutionHandler() { | ||
| public void rejectedExecution(Runnable r, ThreadPoolExecutor executor) { | ||
| if (executor.isShutdown() || executor.isTerminated() || executor.isTerminating()) { | ||
| return; | ||
| } | ||
| ExecutorService fallbackExecutor = getTransactionalExecutor(); | ||
| fallbackExecutor.execute(r); | ||
| }; | ||
| }; | ||
|
|
||
| public String getExecutorName(boolean isTransactional, String identifier) { | ||
| if (isTransactional == true) { | ||
| return name + "TransactionalExecutor" + identifier; | ||
| } | ||
| return name + "Executor" + identifier; | ||
| } | ||
|
|
||
| public void shutdown() { | ||
| Set<String> existingExecutorNames = executors.keySet(); | ||
| existingExecutorNames.removeIf((executorName) -> { | ||
| return executorName.startsWith(name) == false; | ||
| }); | ||
| existingExecutorNames.forEach((executorName) -> { | ||
| removeExecutor(executorName); | ||
| }); | ||
| } | ||
|
|
||
| public void removeExecutor(String executorName) { | ||
| synchronized(executors) { | ||
| ExecutorService existingExecutor = executors.get(executorName); | ||
| if (existingExecutor != null) { | ||
| existingExecutor.shutdownNow(); | ||
| executors.remove(executorName); | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
0e4e331There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully deployed to the following URLs: