Refactoring / Enhancements #8307
Open
+217
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- And serializers - Basic, needs lots of work still
SchrodingersGat
added
order
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8307 +/- ##
==========================================
- Coverage 84.35% 84.30% -0.05%
==========================================
Files 1165 1163 -2
Lines 52845 52853 +8
Branches 1931 1937 +6
==========================================
- Hits 44577 44558 -19
- Misses 7774 7804 +30
+ Partials 494 491 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SchrodingersGat
added
refactor
and removed
order
- Do not request token if other cookies are unavailable - Do not fetch user data if token is unavailable - Prevents connection error logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP PR to provide historical salse information (broken down by month for e.g.) for a particular part.Note: The original intent of this PR is probably better served as a plugin. But there are a number of fixes / improvements which are still good additions.