Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix breadcrumb for <BuildOrderDetail /> #8305

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Fix breadcrumb for <BuildOrderDetail /> #8305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e4d9796
Fix breadcrumb for <BuildOrderDetail />
SchrodingersGat Oct 16, 2024
4d77cdd
Merge branch 'master' into build-url-fix
SchrodingersGat Oct 17, 2024
a6c2285
Add delay for playwright tests
SchrodingersGat Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/frontend/src/pages/build/BuildDetail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ import { ApiEndpoints } from '../../enums/ApiEndpoints';
import { ModelType } from '../../enums/ModelType';
import { UserRoles } from '../../enums/Roles';
import { useBuildOrderFields } from '../../forms/BuildForms';
import { getDetailUrl } from '../../functions/urls';
import {
useCreateApiFormModal,
useEditApiFormModal
Expand Down Expand Up @@ -523,7 +524,10 @@ export default function BuildDetail() {
imageUrl={build.part_detail?.image ?? build.part_detail?.thumbnail}
breadcrumbs={[
{ name: t`Manufacturing`, url: '/manufacturing' },
{ name: build.reference, url: `/build/${build.pk}` }
{
name: build.reference,
url: getDetailUrl(ModelType.build, build.pk)
}
]}
actions={buildActions}
/>
Expand Down
3 changes: 3 additions & 0 deletions src/frontend/tests/pages/pui_stock.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { test } from '../baseFixtures.js';

Check failure on line 1 in src/frontend/tests/pages/pui_stock.spec.ts

View workflow job for this annotation

GitHub Actions / Tests - Platform UI

[chromium] › pages/pui_stock.spec.ts:52:1 › Stock - Serial Numbers 

  1) [chromium] › pages/pui_stock.spec.ts:52:1 › Stock - Serial Numbers ────────────────────────────
    Test timeout of 90000ms exceeded.

Check failure on line 1 in src/frontend/tests/pages/pui_stock.spec.ts

View workflow job for this annotation

GitHub Actions / Tests - Platform UI

[firefox] › pages/pui_stock.spec.ts:52:1 › Stock - Serial Numbers 

  4) [firefox] › pages/pui_stock.spec.ts:52:1 › Stock - Serial Numbers ─────────────────────────────
    Test timeout of 90000ms exceeded.
import { baseUrl } from '../defaults.js';
import { doQuickLogin } from '../login.js';

Expand Down Expand Up @@ -57,7 +57,10 @@
await page.getByLabel('open-search').click();

await page.getByLabel('global-search-input').clear();

await page.waitForTimeout(250);
await page.getByLabel('global-search-input').fill('widget green');
await page.waitForTimeout(250);

// Remove the "stock item" results group
await page.getByLabel('remove-search-group-stockitem').click();
Expand All @@ -74,7 +77,7 @@
await page.getByLabel('action-button-add-stock-item').click();

// Initially fill with invalid serial/quantity combinations
await page.getByLabel('text-field-serial_numbers').fill('200-250');

Check failure on line 80 in src/frontend/tests/pages/pui_stock.spec.ts

View workflow job for this annotation

GitHub Actions / Tests - Platform UI

[chromium] › pages/pui_stock.spec.ts:52:1 › Stock - Serial Numbers 

  1) [chromium] › pages/pui_stock.spec.ts:52:1 › Stock - Serial Numbers ────────────────────────────
    Error: locator.fill: Test timeout of 90000ms exceeded.
    Call log:
      - waiting for getByLabel('text-field-serial_numbers')
      -   locator resolved to <input disabled value="" id=":r561:" type="string" field_type="string" data-disabled="true" aria-invalid="false" data-variant="default" aria-describedby=":r561:-description" aria-label="text-field-serial_numbers" class="m_8fb7ebe7 mantine-Input-input mantine-TextInput-input"/>
      -   fill("200-250")
      - attempting fill action
      -   waiting for element to be visible, enabled and editable
      -   element is not enabled
      - retrying fill action, attempt #1
      -   waiting for element to be visible, enabled and editable
      -   element is not enabled
      - retrying fill action, attempt #2
      -   waiting 20ms
      -   waiting for element to be visible, enabled and editable
      -   element is not enabled
      - retrying fill action, attempt #3
      -   waiting 100ms
      -   waiting for element to be visible, enabled and editable
      -   element is not enabled
      - retrying fill action, attempt #4
      -   waiting 100ms
      -   waiting for element to be visible, enabled and editable
      -   element is not enabled
      - retrying fill action, attempt #5
      -   waiting 500ms
      -   waiting for element to be visible, enabled and editable
      -   element is not enabled
      - retrying fill action, attempt #6
      -   waiting 500ms
      -   waiting for element to be visible, enabled and editable
      -   element is not enabled
      - retrying fill action, attempt #7
      -   waiting 500ms
      -   waiting for element to be visible, enabled and editable
      -   element is not enabled
      - retrying fill action, attempt #8
      -   waiting 500ms
      -   waiting for element to be visible, enabled and editable
      -   element is not enabled
      - retrying fill action, attempt #9
      -   waiting 500ms
      -   waiting for element to be visible, enabled and editable
      -   element is not enabled
      - retrying fill action, attempt #10
      -   waiting 500ms
      -   waiting for element to be visible, enabled and editable
      -   element is not enabled
      - retrying fill action, attempt #11
      -   waiting 500ms
      -   waiting for element to be visible, enabled and editable
      -   element is not enabled
      - retrying fill action, attempt #12
      -   waiting 500ms
      -   waiting for element to be visible, enabled and editable
      -   element is not enabled
      - retrying fill action, attempt #13
      -   waiting 500ms
      -   waiting for element to be visible, enabled and editable
      -   element is not enabled
      - retrying fill action, attempt #14
      -   waiting 500ms
      -   waiting for element to be visible, enabled and editable
      -   element is not enabled
      - retrying fill action, attempt #15
      -   waiting 500ms
      -   waiting for element to be visible, enabled and editable
      -   element is not enabled
      - retrying fill action, attempt #16
      -   waiting 500ms
      -   waiting for element to be visible, enabled and editable
      -   element is not enabled
      - retrying fill action, attempt #17
      -   waiting 500ms
      -   waiting for element to be visible, enabled and editable
      -   element is not enabled
      - retrying fill action, attempt #18
      -   waiting 500ms
      -   waiting for element to be visible, enabled and editable
      -   element is not enabled
      - retrying fill action, attempt #19
      -   waiting 500ms
      -   waiting for element to be visible, enabled and editable
      -   element is not enabled
      - retrying fill action, attempt #20
      -   waiting 500ms
      -   waiting for element to be visible, enabled and editable
      -   element is not enabled
      - retrying fill action, attempt #21
      -   waiting 500ms
      -   waiting for element to be visible, enabled and editable

Check failure on line 80 in src/frontend/tests/pages/pui_stock.spec.ts

View workflow job for this annotation

GitHub Actions / Tests - Platform UI

[firefox] › pages/pui_stock.spec.ts:52:1 › Stock - Serial Numbers 

  4) [firefox] › pages/pui_stock.spec.ts:52:1 › Stock - Serial Numbers ─────────────────────────────
    Error: locator.fill: Test timeout of 90000ms exceeded.
    Call log:
      - waiting for getByLabel('text-field-serial_numbers')
      -   locator resolved to <input disabled value="" id=":r4cv:" type="string" field_type="string" data-disabled="true" aria-invalid="false" data-variant="default" aria-describedby=":r4cv:-description" aria-label="text-field-serial_numbers" class="m_8fb7ebe7 mantine-Input-input mantine-TextInput-input"/>
      -   fill("200-250")
      - attempting fill action
      -   waiting for element to be visible, enabled and editable
      -   element is not enabled
      - retrying fill action, attempt #1
      -   waiting for element to be visible, enabled and editable
      -   element is not enabled
      - retrying fill action, attempt #2
      -   waiting 20ms
      -   waiting for element to be visible, enabled and editable
      -   element is not enabled
      - retrying fill action, attempt #3
      -   waiting 100ms
      -   waiting for element to be visible, enabled and editable
      -   element is not enabled
      - retrying fill action, attempt #4
      -   waiting 100ms
      -   waiting for element to be visible, enabled and editable
      -   element is not enabled
      - retrying fill action, attempt #5
      -   waiting 500ms
      -   waiting for element to be visible, enabled and editable
      -   element is not enabled
      - retrying fill action, attempt #6
      -   waiting 500ms
      -   waiting for element to be visible, enabled and editable
      -   element is not enabled
      - retrying fill action, attempt #7
      -   waiting 500ms
      -   waiting for element to be visible, enabled and editable
      -   element is not enabled
      - retrying fill action, attempt #8
      -   waiting 500ms
      -   waiting for element to be visible, enabled and editable
      -   element is not enabled
      - retrying fill action, attempt #9
      -   waiting 500ms
      -   waiting for element to be visible, enabled and editable
      -   element is not enabled
      - retrying fill action, attempt #10
      -   waiting 500ms
      -   waiting for element to be visible, enabled and editable
      -   element is not enabled
      - retrying fill action, attempt #11
      -   waiting 500ms
      -   waiting for element to be visible, enabled and editable
      -   element is not enabled
      - retrying fill action, attempt #12
      -   waiting 500ms
      -   waiting for element to be visible, enabled and editable
      -   element is not enabled
      - retrying fill action, attempt #13
      -   waiting 500ms
      -   waiting for element to be visible, enabled and editable
      -   element is not enabled
      - retrying fill action, attempt #14
      -   waiting 500ms
      -   waiting for element to be visible, enabled and editable
      -   element is not enabled
      - retrying fill action, attempt #15
      -   waiting 500ms
      -   waiting for element to be visible, enabled and editable
      -   element is not enabled
      - retrying fill action, attempt #16
      -   waiting 500ms
      -   waiting for element to be visible, enabled and editable
      -   element is not enabled
      - retrying fill action, attempt #17
      -   waiting 500ms
      -   waiting for element to be visible, enabled and editable
      -   element is not enabled
      - retrying fill action, attempt #18
      -   waiting 500ms
      -   waiting for element to be visible, enabled and editable
      -   element is not enabled
      - retrying fill action, attempt #19
      -   waiting 500ms
      -   waiting for element to be visible, enabled and editable
      -   element is not enabled
      - retrying fill action, attempt #20
      -   waiting 500ms
      -   waiting for element to be visible, enabled and editable
      -   element is not enabled
      - retrying fill action, attempt #21
      -   waiting 500ms
      -   waiting for element to be visible, enabled and editable
await page.getByLabel('number-field-quantity').fill('10');

await page.getByRole('button', { name: 'Submit' }).click();
Expand Down
Loading