Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to old setting #8018

Merged
merged 9 commits into from
Sep 6, 2024

Conversation

SchrodingersGat
Copy link
Member

@SchrodingersGat SchrodingersGat commented Aug 28, 2024

After the report generation refactor we no longer separate report generation concepts based on the "target" of the report.

This PR removes two settings which are no longer relevant.

- Now offloaded to plugins
@SchrodingersGat SchrodingersGat added this to the 0.17.0 milestone Aug 28, 2024
Copy link

netlify bot commented Aug 28, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit f522171
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/66da86aabedcb00008389c69
😎 Deploy Preview https://deploy-preview-8018--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 1 from production)
Accessibility: 86 (no change from production)
Best Practices: 92 (no change from production)
SEO: 70 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SchrodingersGat SchrodingersGat added the report Report/Label generation label Aug 28, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.83%. Comparing base (9f92475) to head (f522171).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8018      +/-   ##
==========================================
+ Coverage   83.79%   83.83%   +0.03%     
==========================================
  Files        1142     1143       +1     
  Lines       50997    51016      +19     
  Branches     1786     1786              
==========================================
+ Hits        42735    42770      +35     
+ Misses       7815     7797      -18     
- Partials      447      449       +2     
Flag Coverage Δ
backend 85.71% <100.00%> (+<0.01%) ⬆️
pui 65.14% <100.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

matmair added a commit to matmair/InvenTree that referenced this pull request Sep 1, 2024
SchrodingersGat pushed a commit that referenced this pull request Sep 2, 2024
* add test for asset redirect

* fully cover spa_bundler

* test token api

* check without beeing authed

* not possible to be reached - no cover

* remove unneeded except

* fully test group apis

* move ignore

* add tests for admin site

* add full admin testing

* use output as ref

* ignore admin edge-case

* test display name settings

* refactor admin test

* add more admin testing

* fix tests assertation

* fix assertations

* add test for importer admin

* remove old test for function that will not be re-added for now
see #8018 (comment)

* Add stock detail with wrong pk

* add a few stock tests
@SchrodingersGat SchrodingersGat merged commit 07fac28 into inventree:master Sep 6, 2024
26 checks passed
@SchrodingersGat SchrodingersGat deleted the report-attach branch September 6, 2024 05:15
@matmair matmair mentioned this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor report Report/Label generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants