-
-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PUI] Add image based QR code assigment #7960
Conversation
…add-image-scan
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7960 +/- ##
==========================================
- Coverage 83.60% 83.51% -0.10%
==========================================
Files 1136 1140 +4
Lines 50905 51009 +104
Branches 1758 1776 +18
==========================================
+ Hits 42560 42600 +40
- Misses 7899 7950 +51
- Partials 446 459 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This already looks pretty good. I like that there is a select to use a different camera (this is pretty useful in safari to use the iPhone camera as a scanner). I have to suggestions to improve the design.
Maybe this component can be also used later for the related model field to just input barcode data there. |
Ready for review and merge if @wolflu05 is happy |
@matmair looks good to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the design adjustments. It looks great now.
Follow up to #7939
This adds a button to scan codes for barcode linking.
I am not sure about the styling and would be thankful for feedback.
New look for barcode linking
Current look for general QR scans: