Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PUI] Fix for BOM pricing donut chart #7917

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

SchrodingersGat
Copy link
Member

  • Mantine charts tooltip can't handle '.' character.

- Mantine charts tooltip can't handle '.' character.
@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed user interface User interface pricing Pricing functionality backport Apply this label to a PR to enable auto-backport action Platform UI Related to the React based User Interface backport-to-0.16.x labels Aug 19, 2024
@SchrodingersGat SchrodingersGat added this to the 0.17.0 milestone Aug 19, 2024
Copy link

netlify bot commented Aug 19, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 58850c9
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/66c2d9f1e228ca000814a91e
😎 Deploy Preview https://deploy-preview-7917--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 92 (no change from production)
SEO: 70 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@matmair matmair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM;
Is this bug reported upstream? Does not seem like something that is intended

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.53%. Comparing base (2e10400) to head (58850c9).
Report is 4 commits behind head on master.

Files Patch % Lines
...rontend/src/pages/part/pricing/BomPricingPanel.tsx 66.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7917      +/-   ##
==========================================
+ Coverage   83.45%   83.53%   +0.07%     
==========================================
  Files        1131     1131              
  Lines       50373    50383      +10     
  Branches     1745     1752       +7     
==========================================
+ Hits        42040    42087      +47     
+ Misses       7895     7838      -57     
- Partials      438      458      +20     
Flag Coverage Δ
pui 65.59% <66.66%> (+0.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit d7d908b into inventree:master Aug 19, 2024
32 checks passed
@SchrodingersGat SchrodingersGat deleted the part-pricing-fix branch August 19, 2024 06:33
github-actions bot pushed a commit that referenced this pull request Aug 19, 2024
- Mantine charts tooltip can't handle '.' character.

(cherry picked from commit d7d908b)
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
0.16.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

SchrodingersGat added a commit that referenced this pull request Aug 19, 2024
- Mantine charts tooltip can't handle '.' character.

(cherry picked from commit d7d908b)

Co-authored-by: Oliver <oliver.henry.walters@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Apply this label to a PR to enable auto-backport action backport-to-0.16.x bug Identifies a bug which needs to be addressed Platform UI Related to the React based User Interface pricing Pricing functionality user interface User interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants