Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PUI] Fix settings indentation #7905

Merged

Conversation

matmair
Copy link
Member

@matmair matmair commented Aug 18, 2024

Fixes an extra indentation that appears when first and last name are empty.

Closes invenhost#104

@matmair matmair added bug Identifies a bug which needs to be addressed Platform UI Related to the React based User Interface labels Aug 18, 2024
@matmair matmair added this to the 0.17.0 milestone Aug 18, 2024
@matmair matmair self-assigned this Aug 18, 2024
Copy link

netlify bot commented Aug 18, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 3d5753b
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/66c265dc65b43f0008c5a3f8
😎 Deploy Preview https://deploy-preview-7905--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 92 (no change from production)
SEO: 70 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Aug 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.42%. Comparing base (7178b95) to head (3d5753b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7905      +/-   ##
==========================================
- Coverage   83.48%   83.42%   -0.06%     
==========================================
  Files        1131     1131              
  Lines       50359    50361       +2     
  Branches     1740     1742       +2     
==========================================
- Hits        42042    42014      -28     
- Misses       7869     7903      +34     
+ Partials      448      444       -4     
Flag Coverage Δ
pui 64.86% <100.00%> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat added the user interface User interface label Aug 18, 2024
@SchrodingersGat SchrodingersGat merged commit 8bf4ce5 into inventree:master Aug 18, 2024
29 checks passed
@SchrodingersGat SchrodingersGat deleted the pui-fix-settings-intentation branch August 18, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Identifies a bug which needs to be addressed Platform UI Related to the React based User Interface user interface User interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User settings: Intentation with no username set
2 participants