Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for usePartFields #7880

Merged

Conversation

SchrodingersGat
Copy link
Member

@SchrodingersGat SchrodingersGat added user interface User interface refactor Platform UI Related to the React based User Interface labels Aug 14, 2024
@SchrodingersGat SchrodingersGat added this to the 0.17.0 milestone Aug 14, 2024
Copy link

netlify bot commented Aug 14, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 26ce35a
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/66bc7efea7e6cf000884c014
😎 Deploy Preview https://deploy-preview-7880--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 92 (no change from production)
SEO: 70 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@wolflu05 wolflu05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this should trigger an update of the useMemo now if the global settings state changes somehow. Not sure if your change before has worked (I'm away from the computer so I haven't tested this, just thought this might not have worked as expected before, so I commented).

@SchrodingersGat SchrodingersGat merged commit 8369b4a into inventree:master Aug 14, 2024
25 checks passed
@SchrodingersGat SchrodingersGat deleted the use-part-fields-take-2 branch August 14, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform UI Related to the React based User Interface refactor user interface User interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants