Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PUI] Tweaks #7843

Merged
merged 4 commits into from
Aug 9, 2024
Merged

[PUI] Tweaks #7843

merged 4 commits into from
Aug 9, 2024

Conversation

SchrodingersGat
Copy link
Member

Small improvements for PUI

@SchrodingersGat SchrodingersGat added user interface User interface Platform UI Related to the React based User Interface labels Aug 9, 2024
@SchrodingersGat SchrodingersGat added this to the 0.17.0 milestone Aug 9, 2024
Copy link

netlify bot commented Aug 9, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 237f430
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/66b5b4b6b13acf000842815e
😎 Deploy Preview https://deploy-preview-7843--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 92 (no change from production)
SEO: 70 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@matmair matmair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 5.00000% with 19 lines in your changes missing coverage. Please review.

Project coverage is 83.60%. Comparing base (21f623e) to head (237f430).

Files Patch % Lines
...frontend/src/tables/part/PartTestTemplateTable.tsx 6.66% 14 Missing ⚠️
src/frontend/src/tables/build/BuildLineTable.tsx 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7843      +/-   ##
==========================================
+ Coverage   83.59%   83.60%   +0.01%     
==========================================
  Files        1127     1127              
  Lines       50215    50225      +10     
  Branches     1711     1718       +7     
==========================================
+ Hits        41977    41992      +15     
+ Misses       7799     7792       -7     
- Partials      439      441       +2     
Flag Coverage Δ
pui 65.68% <5.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit d68d52b into inventree:master Aug 9, 2024
28 checks passed
@SchrodingersGat SchrodingersGat deleted the pui-tweaks branch August 9, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform UI Related to the React based User Interface user interface User interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants