Adjust docker labels to modern OCI schema #7773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This is probably better to be merged after the 0.16.0 release - not needed immediately |
this gets provided by the version ci script
|
This is ready for review |
| @@ -11,6 +11,7 @@ | |||
|
|
|||
| ARG base_image=python:3.11-alpine3.18 | |||
| FROM ${base_image} AS inventree_base | |||
| ARG base_image | |||
There was a problem hiding this comment.
Why hvae you added a blank base_image arg here? Won't this null out the default value?
There was a problem hiding this comment.
No, it is a redefinition to carry the value over to this step from the previous one as ARGs are scoped per step. So the value as was definied in the previous step will be used.
https://docs.docker.com/reference/dockerfile/#scope
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: