Add option to disable MFA #7747
Conversation
SchrodingersGat
added
the
setup
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7747 +/- ##
==========================================
+ Coverage 83.63% 83.72% +0.09%
==========================================
Files 1118 1118
Lines 49549 49574 +25
Branches 1625 1627 +2
==========================================
+ Hits 41441 41508 +67
+ Misses 7680 7643 -37
+ Partials 428 423 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@SchrodingersGat would it not be easier and less error prone to stop addition of new factors? That would be a much smaller diff and less logic branches that could cause issues. If you are interested I can code that up as a comparison. |
|
I thought about also suggesting that. That would be much easier. |
|
@matmair sure, if you can suggest a cleaner alternative I'd be happier with that. This did turn out a bit clunky. |
|
@SchrodingersGat https://github.com/matmair/InvenTree/tree/disable-mfa-ref would be a minial implementation without frontend changes |
|
@matmair that looks cleaner. Can you submit a PR? |
* Add changes from #7747 * disable addition of factors * rename variable
Adds installation level option to disable MFA entirely.
By default, MFA is enabled, and requires manual intervention (at the sysadmin level) to turn it off.
This would be useful for installations where MFA is explicitly not wanted - for now, this is intended for the demo server.