Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make libffi version more flexible #7734

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Make libffi version more flexible #7734

merged 3 commits into from
Jul 25, 2024

Conversation

matmair
Copy link
Member

@matmair matmair commented Jul 24, 2024 •
edited
Loading

Can not install on debian 12 due to the hard-pinning of libffi to version 7 and a wrong repo address.
Both are fixes with this PR.
Fixes #6036

@matmair
Make libffi version more flexible
1981dc1 
Can not install on debian 12
Fixes inventree#6036
@matmair matmair added setup Relates to the InvenTree setup / installation process installer backport-to-0.15.x labels Jul 24, 2024
@matmair matmair added this to the 0.15.7 milestone Jul 24, 2024
@matmair matmair self-assigned this Jul 24, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 24, 2024 •
edited
Loading

✅ Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit aad9e84
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/66a177d29c26150008418a15
😎 Deploy Preview https://deploy-preview-7734--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 92 (no change from production)
SEO: 70 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@matmair
target v11 packaging on v12 install
a3f5a62 
we are only targeting one version per debian / ubuntu channel. This should not present a problem
@matmair
Merge branch 'master' into matmair/issue6036
aad9e84
@matmair matmair marked this pull request as ready for review July 24, 2024 21:53
@matmair
Copy link
Member Author

matmair commented Jul 25, 2024

@SchrodingersGat this is ready for review and merge

@SchrodingersGat SchrodingersGat added the backport Apply this label to a PR to enable auto-backport action label Jul 25, 2024
@SchrodingersGat
Copy link
Member

@matmair nice work figuring this out

@SchrodingersGat SchrodingersGat merged commit 4edea65 into inventree:master Jul 25, 2024
22 checks passed
@SchrodingersGat SchrodingersGat deleted the matmair/issue6036 branch July 25, 2024 11:55
github-actions bot pushed a commit that referenced this pull request Jul 25, 2024
@matmair
Make libffi version more flexible (#7734)
bdf1b77 
* Make libffi version more flexible
Can not install on debian 12
Fixes #6036

* target v11 packaging on v12 install
we are only targeting one version per debian / ubuntu channel. This should not present a problem

(cherry picked from commit 4edea65)
@github-actions github-actions bot mentioned this pull request Jul 25, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 0.15.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

SchrodingersGat pushed a commit that referenced this pull request Jul 26, 2024
@github-actions @matmair
Make libffi version more flexible (#7734) (#7738)
e5a36f6 
* Make libffi version more flexible
Can not install on debian 12
Fixes #6036

* target v11 packaging on v12 install
we are only targeting one version per debian / ubuntu channel. This should not present a problem

(cherry picked from commit 4edea65)

Co-authored-by: Matthias Mair <code@mjmair.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SchrodingersGat SchrodingersGat Awaiting requested review from SchrodingersGat SchrodingersGat is a code owner

Assignees

@matmair matmair

Labels
backport Apply this label to a PR to enable auto-backport action installer setup Relates to the InvenTree setup / installation process
Projects
None yet
Milestone
0.15.7
Development

Successfully merging this pull request may close these issues.

Can not install on debian 12
2 participants
@matmair @SchrodingersGat