-
-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
try to fix tests #7730
try to fix tests #7730
Conversation
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7730 +/- ##
==========================================
- Coverage 83.70% 83.67% -0.04%
==========================================
Files 1118 1118
Lines 49542 49542
Branches 1625 1625
==========================================
- Hits 41469 41452 -17
- Misses 7641 7662 +21
+ Partials 432 428 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
Im trying to debug this issue. What I already found out:
|
Maybe the issue is in the testing code itself? |
I also found that updating to the latest version of |
You're right, updating "fixed" the issues. (See my last run). Feel free to change this pr if I did something wrong upgrading the package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; great that we figured that out
Nice work, thanks @wolflu05 |
This PR fixes the failing migrations tests first discovered after the merge of #7684 in: https://github.com/inventree/InvenTree/actions/runs/10069548588/job/27836706327
https://github.com/inventree/InvenTree/actions/runs/10069548597/job/27838227324
Somehow this seems to not be directly related to that PR, but was first caught after that merge. It may be related to wemake-services/django-test-migrations#294 ? Because when upgrading to 1.4.0 from 1.3.0 the issue is gone.