Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to fix tests #7730

Merged
merged 6 commits into from
Jul 26, 2024
Merged

try to fix tests #7730

merged 6 commits into from
Jul 26, 2024

Conversation

wolflu05
Copy link
Contributor

@wolflu05 wolflu05 commented Jul 24, 2024

This PR fixes the failing migrations tests first discovered after the merge of #7684 in: https://github.com/inventree/InvenTree/actions/runs/10069548588/job/27836706327
https://github.com/inventree/InvenTree/actions/runs/10069548597/job/27838227324

Somehow this seems to not be directly related to that PR, but was first caught after that merge. It may be related to wemake-services/django-test-migrations#294 ? Because when upgrading to 1.4.0 from 1.3.0 the issue is gone.

@wolflu05 wolflu05 added the full-run Always do a full QC CI run label Jul 24, 2024
Copy link

netlify bot commented Jul 24, 2024

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit 71d9ab6
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/66a2787f756b720008a88b8b

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.67%. Comparing base (96abd08) to head (71d9ab6).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7730      +/-   ##
==========================================
- Coverage   83.70%   83.67%   -0.04%     
==========================================
  Files        1118     1118              
  Lines       49542    49542              
  Branches     1625     1625              
==========================================
- Hits        41469    41452      -17     
- Misses       7641     7662      +21     
+ Partials      432      428       -4     
Flag Coverage Δ
backend 85.37% <ø> (ø)
migrations 42.47% <ø> (+0.02%) ⬆️
pui 64.47% <ø> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wolflu05 wolflu05 requested a review from matmair as a code owner July 24, 2024 15:21
Copy link

sonarcloud bot commented Jul 24, 2024

@wolflu05
Copy link
Contributor Author

Im trying to debug this issue. What I already found out:

  1. when reverting back to the commit prior to my icons merge commit, the migration tests pass
  2. when removing the separate database and state operations and place the unnecessary migrations directly in the operations list, it's still not working
  3. somehow this seems to not be the the correct instance of part, was trying to debug that with my last run

@matmair
Copy link
Member

matmair commented Jul 24, 2024

Maybe the issue is in the testing code itself?

@SchrodingersGat
Copy link
Member

I also found that updating to the latest version of django-test-migrations "fixed" the tests too....

@wolflu05
Copy link
Contributor Author

wolflu05 commented Jul 24, 2024

You're right, updating "fixed" the issues. (See my last run). Feel free to change this pr if I did something wrong upgrading the package.

Copy link
Member

@matmair matmair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; great that we figured that out

@wolflu05 wolflu05 added the bug Identifies a bug which needs to be addressed label Jul 25, 2024
@wolflu05 wolflu05 added this to the 0.16.0 milestone Jul 25, 2024
@SchrodingersGat
Copy link
Member

Nice work, thanks @wolflu05

@SchrodingersGat SchrodingersGat merged commit 43656d6 into inventree:master Jul 26, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Identifies a bug which needs to be addressed full-run Always do a full QC CI run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants