Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cast width / height to integer #7676

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Cast width / height to integer #7676

merged 2 commits into from
Jul 18, 2024

Conversation

SchrodingersGat
Copy link
Member

  • Cast values provided to image helper function
  • Prevent issues with incorrect types

@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed report Report/Label generation backport Apply this label to a PR to enable auto-backport action backport-to-0.15.x labels Jul 18, 2024
@SchrodingersGat SchrodingersGat added this to the 0.16.0 milestone Jul 18, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 18, 2024 •
edited
Loading

✅ Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit 1e1ed13
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/66987b9503024600082048ca

@SchrodingersGat SchrodingersGat merged commit ecec81e into inventree:master Jul 18, 2024
21 checks passed
@SchrodingersGat SchrodingersGat deleted the img-helper-fixes branch July 18, 2024 02:38
github-actions bot pushed a commit that referenced this pull request Jul 18, 2024
@SchrodingersGat
Cast width / height to integer (#7676)
57accbb 
* Cast width / height to integer

* Convert "rotate" parameter

(cherry picked from commit ecec81e)
@github-actions github-actions bot mentioned this pull request Jul 18, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 0.15.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

SchrodingersGat added a commit that referenced this pull request Jul 18, 2024
@github-actions @SchrodingersGat
Cast width / height to integer (#7676) (#7677)
c1d9732 
* Cast width / height to integer

* Convert "rotate" parameter

(cherry picked from commit ecec81e)

Co-authored-by: Oliver <oliver.henry.walters@gmail.com>
@codecov Codecov
Copy link

codecov bot commented Oct 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 31.25000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 83.71%. Comparing base (dae173e) to head (1e1ed13).
Report is 311 commits behind head on master.

Files with missing lines Patch % Lines
...rc/backend/InvenTree/report/templatetags/report.py 31.25% 11 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7676      +/-   ##
==========================================
- Coverage   83.72%   83.71%   -0.02%     
==========================================
  Files        1104     1104              
  Lines       48801    48814      +13     
  Branches     1568     1568              
==========================================
+ Hits        40860    40863       +3     
- Misses       7540     7550      +10     
  Partials      401      401
Flag Coverage Δ
backend 85.21% <31.25%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport Apply this label to a PR to enable auto-backport action bug Identifies a bug which needs to be addressed report Report/Label generation
Projects
None yet
Milestone
0.16.0
Development

Successfully merging this pull request may close these issues.
1 participant
@SchrodingersGat