Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize PUI package delivery for package installs #7655

Merged
merged 41 commits into from
Jul 18, 2024

Conversation

matmair
Copy link
Member

@matmair matmair commented Jul 15, 2024

This PR:

  • Adds git commit identifiers to the frontend CI-builds
  • Includes the frontend resources with tag-builds of the package
  • Adds a check to the frontend-download to ensure the frontend is only downloaded when necessary
  • Adds better readable package build logs

It does not fix #7338 in all cases as the frontend can only by downloaded automatically for tagged releases

@matmair matmair added setup Relates to the InvenTree setup / installation process installer labels Jul 15, 2024
@matmair matmair added this to the 0.16.0 milestone Jul 15, 2024
@matmair matmair self-assigned this Jul 15, 2024
Copy link

netlify bot commented Jul 15, 2024

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit 5543709
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/6695bf3c59870800083eac04

* Package frontend in deb

* Add artifact download

* remove 0.8.0 check

* remove array casting

* fix format once more

* another try

* add brackets again

* add version

* and bash

* and shell

* more debuging

* various style fixes

* small fixes

* and ls for prosperity

* debug

* maybe git as source?

* fix download cmd?

* debug a bit

* debug a bit more

* remove sha download - is not working with GHA restrictions

* write version number

* check if a new frontend must be dowloaded

* write versions into frontend packages
@matmair
Copy link
Member Author

matmair commented Jul 16, 2024

Now fixes #7338 for tagged releases (stable channel). Will need #5278 (comment) to fix all (future) builds

@matmair matmair changed the title Optimize PUI delivery for package installs Optimize PUI package delivery for package installs Jul 17, 2024
@SchrodingersGat
Copy link
Member

@matmair g2g on this one?

@matmair matmair added backport Apply this label to a PR to enable auto-backport action backport-to-0.15.x labels Jul 18, 2024
@matmair
Copy link
Member Author

matmair commented Jul 18, 2024

@SchrodingersGat yes!

@SchrodingersGat SchrodingersGat merged commit 105dd71 into inventree:master Jul 18, 2024
23 checks passed
@SchrodingersGat SchrodingersGat deleted the matmair/issue7338 branch July 18, 2024 05:35
Copy link
Contributor

💔 All backports failed

Status Branch Result
0.15.x An unhandled error occurred. Please see the logs for details

Manual backport

To create the backport manually run:

backport --pr 7655

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

matmair added a commit to matmair/InvenTree that referenced this pull request Jul 18, 2024
SchrodingersGat pushed a commit that referenced this pull request Jul 18, 2024
SchrodingersGat pushed a commit that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Apply this label to a PR to enable auto-backport action installer setup Relates to the InvenTree setup / installation process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Installer] Issue downloading frontend
2 participants