Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various SAST fixes #7644

Merged
merged 12 commits into from
Jul 17, 2024
Merged

Conversation

matmair
Copy link
Member

@matmair matmair commented Jul 13, 2024

More small reliability/maintainability fixes from SAST warnings.

@matmair matmair added this to the 0.16.0 milestone Jul 13, 2024
@matmair matmair self-assigned this Jul 13, 2024
Copy link

netlify bot commented Jul 13, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit e6cece1
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/6695a3037926eb0008c79e8e
😎 Deploy Preview https://deploy-preview-7644--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 92 (no change from production)
SEO: 70 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.74%. Comparing base (b96b8b8) to head (e6cece1).
Report is 321 commits behind head on master.

Files with missing lines Patch % Lines
...s/editors/TemplateEditor/PdfPreview/PdfPreview.tsx 0.00% 1 Missing ⚠️
src/frontend/src/tables/InvenTreeTable.tsx 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7644      +/-   ##
==========================================
- Coverage   83.75%   83.74%   -0.02%     
==========================================
  Files        1102     1102              
  Lines       48694    48696       +2     
  Branches     1550     1551       +1     
==========================================
- Hits        40786    40782       -4     
- Misses       7511     7516       +5     
- Partials      397      398       +1     
Flag Coverage Δ
backend 85.23% <100.00%> (+<0.01%) ⬆️
pui 65.05% <77.77%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matmair
Copy link
Member Author

matmair commented Jul 16, 2024

@SchrodingersGat found the CI problem

@SchrodingersGat
Copy link
Member

@matmair what was the issue?

@matmair
Copy link
Member Author

matmair commented Jul 17, 2024

@SchrodingersGat The StylishText component causes errors when getting empty children passed in so I reveres the change in that area

@SchrodingersGat
Copy link
Member

Nice :) Happy for me to merge this then?

@matmair
Copy link
Member Author

matmair commented Jul 17, 2024

@SchrodingersGat yes, ready for merge

@SchrodingersGat SchrodingersGat merged commit 547fa17 into inventree:master Jul 17, 2024
25 checks passed
@SchrodingersGat SchrodingersGat deleted the more-random-fixes branch July 17, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants