Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various small code quality cleanups #7626

Merged
merged 15 commits into from
Jul 11, 2024
Merged

Conversation

matmair
Copy link
Member

@matmair matmair commented Jul 11, 2024

Various cleanups that were recommended from our SAST tooling.

@matmair matmair added this to the 0.16.0 milestone Jul 11, 2024
@matmair matmair self-assigned this Jul 11, 2024
Copy link

netlify bot commented Jul 11, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 5c94999
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/6690572e4ffe3400084139fa
😎 Deploy Preview https://deploy-preview-7626--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 92 (no change from production)
SEO: 70 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.05%. Comparing base (be2beec) to head (5c94999).
Report is 322 commits behind head on master.

Files with missing lines Patch % Lines
src/frontend/src/tables/settings/GroupTable.tsx 0.00% 2 Missing ⚠️
src/backend/InvenTree/InvenTree/tracing.py 0.00% 1 Missing ⚠️
src/backend/InvenTree/stock/models.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7626      +/-   ##
==========================================
+ Coverage   84.01%   84.05%   +0.04%     
==========================================
  Files        1095     1095              
  Lines       48165    48165              
  Branches     1490     1489       -1     
==========================================
+ Hits        40464    40487      +23     
+ Misses       7306     7276      -30     
- Partials      395      402       +7     
Flag Coverage Δ
backend 85.27% <33.33%> (ø)
pui 66.17% <33.33%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit 3d82354 into inventree:master Jul 11, 2024
25 checks passed
@SchrodingersGat SchrodingersGat deleted the cleanup branch July 11, 2024 23:07
@SchrodingersGat
Copy link
Member

@matmair appreciated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants