Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues made in #7614 #7622

Merged
merged 4 commits into from
Jul 13, 2024

Conversation

martonmiklos
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Jul 11, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 624b391
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/6691ac9c2d82780008a943b3
😎 Deploy Preview https://deploy-preview-7622--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 92 (no change from production)
SEO: 70 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.06%. Comparing base (c87b5c8) to head (624b391).
Report is 319 commits behind head on master.

Files with missing lines Patch % Lines
...end/InvenTree/plugin/builtin/labels/label_sheet.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7622      +/-   ##
==========================================
- Coverage   84.10%   84.06%   -0.05%     
==========================================
  Files        1094     1096       +2     
  Lines       48336    48293      -43     
  Branches     1492     1474      -18     
==========================================
- Hits        40653    40597      -56     
- Misses       7291     7301      +10     
- Partials      392      395       +3     
Flag Coverage Δ
backend 85.30% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit e5814ea into inventree:master Jul 13, 2024
25 checks passed
@SchrodingersGat
Copy link
Member

Thanks for the fix @martonmiklos

@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed plugin Plugin ecosystem report Report/Label generation labels Jul 13, 2024
@SchrodingersGat SchrodingersGat added this to the 0.16.0 milestone Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Identifies a bug which needs to be addressed plugin Plugin ecosystem report Report/Label generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants