Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add substitute details to BOM export #7563

Merged
merged 5 commits into from
Jul 26, 2024

Conversation

mredpath2
Copy link
Contributor

The following changes to BOM Export as per #5179 :

  1. Added substitute part IPN to BOM export when "Include Alternative Parts" is selected
  2. Add Part Revision to BOM export as requested by @hugozijlmans

I also thought about adding substitute manufacturer and supplier details. But I wasn't sure if this would clog up the BOM export with too many columns if there were multiple alternates and they each had multiple SPN and MPN? So, I haven't included this change.

Closes #5179

Copy link

netlify bot commented Jul 5, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit c4ac76a
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/66a16d530dc8d40009144b99
😎 Deploy Preview https://deploy-preview-7563--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 92 (no change from production)
SEO: 70 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SchrodingersGat SchrodingersGat added enhancement This is an suggested enhancement or new feature import / export Data importing, exporting and processing labels Jul 5, 2024
@SchrodingersGat
Copy link
Member

@mredpath2 thanks for the additions :)

@SchrodingersGat
Copy link
Member

You will need to address the style issues so that the rest of the tests can run

@mredpath2
Copy link
Contributor Author

You will need to address the style issues so that the rest of the tests can run

Should be resolved now :)

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 83.69%. Comparing base (96abd08) to head (c4ac76a).
Report is 2 commits behind head on master.

Files Patch % Lines
src/backend/InvenTree/part/bom.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7563      +/-   ##
==========================================
- Coverage   83.70%   83.69%   -0.01%     
==========================================
  Files        1118     1118              
  Lines       49542    49549       +7     
  Branches     1625     1625              
==========================================
+ Hits        41469    41470       +1     
- Misses       7641     7647       +6     
  Partials      432      432              
Flag Coverage Δ
backend 85.35% <14.28%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat
Copy link
Member

@mredpath2 you will also need to update the unit test which checks the columns in the generated BOM file:

image

@matmair matmair added this to the 0.16.0 milestone Jul 24, 2024
Copy link
Member

@matmair matmair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

@hugozijlmans
Copy link

Thanks @mredpath2. I'm not sure if many people were missing this feature however I'm very glad it's implemented as usually we use partnumber as BOM line item but for custom items (in our case PCB or PCBA) it's very helpfull to use the revision to show it's still the same part but a new version.

@SchrodingersGat SchrodingersGat merged commit 86fb9f0 into inventree:master Jul 26, 2024
26 checks passed
@SchrodingersGat
Copy link
Member

@mredpath2 thanks for the contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an suggested enhancement or new feature import / export Data importing, exporting and processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Add substitute details to BOM export
4 participants