-
-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add substitute details to BOM export #7563
Add substitute details to BOM export #7563
Conversation
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@mredpath2 thanks for the additions :) |
You will need to address the style issues so that the rest of the tests can run |
Should be resolved now :) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7563 +/- ##
==========================================
- Coverage 83.70% 83.69% -0.01%
==========================================
Files 1118 1118
Lines 49542 49549 +7
Branches 1625 1625
==========================================
+ Hits 41469 41470 +1
- Misses 7641 7647 +6
Partials 432 432
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@mredpath2 you will also need to update the unit test which checks the columns in the generated BOM file: |
a8991a9
to
e03b95c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great!
Thanks @mredpath2. I'm not sure if many people were missing this feature however I'm very glad it's implemented as usually we use partnumber as BOM line item but for custom items (in our case PCB or PCBA) it's very helpfull to use the revision to show it's still the same part but a new version. |
@mredpath2 thanks for the contribution :) |
The following changes to BOM Export as per #5179 :
I also thought about adding substitute manufacturer and supplier details. But I wasn't sure if this would clog up the BOM export with too many columns if there were multiple alternates and they each had multiple SPN and MPN? So, I haven't included this change.
Closes #5179