-
-
Notifications
You must be signed in to change notification settings - Fork 761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first implementation of improved docker #6305
Conversation
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Looks intresting @ChristianSchindler - could you expand the description of the PR a bit more? |
I have some concerns that this goes against docker best practice Process ReliabilityIf one of the processes (web worker, background worker) fails - this may be obscured by this update. The docker container generally manages process state, and allows auto-restart of the process due to an error LoggingAgain, running a background process in the docker container may obscure logs - which are crucial for debugging InvenTree performance. ScalabilityWhile "simplifying" the docker container setup, this reduces the flexibility of the setup. I'd like to hear your thoughts on the potential advantages. Maybe I am missing something here, but the |
If I can do it so that if one fails, the complete container restarts, is this ok?
I know that's why I made it so that both still print out and also add in front
If you want to scale, this is still entirely possible. Then you can use it without the script similar to it is now, but most will not need it, and that's a way for it to be as easy as possible. |
In gennerla ther are two changes:
|
Please ammend your explaination to the PR description to make it easier to find |
@ChristianSchindler We will not merge this with a combined worker and server container in the compose due to the resons listed by @SchrodingersGat above. |
Sorry had no time will look at it next week |
Based on: #6303
Improve Docker Image:
invoke update
Automatically on image updates