Issued by filter #5515
Merged
Issued by filter #5515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for inventree ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
wolflu05
reviewed
Sep 7, 2023
InvenTree/InvenTree/api_version.py
Outdated
| @@ -2,11 +2,14 @@ | |||
|
|
|||
|
|
|||
| # InvenTree API version | |||
| INVENTREE_API_VERSION = 131 | |||
| INVENTREE_API_VERSION = 133 | |||
There was a problem hiding this comment.
Nice catch, thanks
wolflu05
reviewed
Sep 7, 2023
Comment on lines
+31
to
+35
| for (let user of response) { | ||
| users[user.pk] = { | ||
| key: user.pk, | ||
| value: user.username | ||
| }; |
There was a problem hiding this comment.
Just if you want to learn something more modern, you could do it with reduce like:
response.reduce((users, user) => ({...users, [user.pk]: { key: user.pk, value: user.username }}), {})Or using the map function and Object.fromEntries in combination.
There was a problem hiding this comment.
Thanks @wolflu05 for the tip. This will all soon be replaced with React - and I am certainly focusing on writing more up-to-date code over there :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow build order table data to be filtered by which user issued the order