[WIP] Mantine datatables #5218
[WIP] Mantine datatables #5218
Conversation
Update deps
Create scan.yml
Add settings sections
rename scan action
Add user settings
| }, | ||
| server: { | ||
| watch: { | ||
| usePolling: true | ||
| } |
There was a problem hiding this comment.
Why do we need polling, doesn't the default websocket works better?
There was a problem hiding this comment.
On my setup (devcontainer / windows10 / wsl2) polling and auto-reload doesn't work without this setting. I will happily revert this if you can help me work it out :)
There was a problem hiding this comment.
@SchrodingersGat why do you added this here? I also have a few other comments here.
There was a problem hiding this comment.
Did you see my previous comment? On my setup (windows / devcontainer) it won't auto-reload unless I have this configured.
There was a problem hiding this comment.
No, because you haven't posted it before, you just added comments that were pending and now you commented all of them.
There was a problem hiding this comment.
Maybe we can apply this setting conditionally like checking if we run on windows.
There was a problem hiding this comment.
Something like:
| }, | |
| server: { | |
| watch: { | |
| usePolling: true | |
| } | |
| }, | |
| server: { | |
| watch: { | |
| usePolling: process.platform === "win32" | |
| } |
Current draft is to have a button which shows number of active filters, click to expand:
Still pretty rough, but the mechanics are getting there |
- Save active filters to local storage - Add some example filters to the part table - Add FilterBadge component
- useDebouncedValue
# Conflicts: # src/frontend/src/defaults/links.tsx # src/frontend/src/router.tsx
- Allow choices to be specified as attribute - Allow choices to be specified as function - Handle state management for filter choice form
|
Custom filters are now working quite well. The UX might need a bit of polish, but the functionality is all there:
|
|
There are some unresolved conversations. I do not have permissions to resolve them so maybe you should take a look at that and see what has already been addressed. |
|
Ok, merging this one in - any issues pop up we can address them. But it will be good to have this framework in place to work frmo |
| }) { | ||
|
|
||
| // Check if any columns are switchable (can be hidden) | ||
| const hasSwitchableColumns = columns.some((col: any) => col.switchable); |
There was a problem hiding this comment.
@wolflu05 can you provide an example of what that would look like? Still getting my head around react :)
| }, | ||
| server: { | ||
| watch: { | ||
| usePolling: true | ||
| } |
There was a problem hiding this comment.
Did you see my previous comment? On my setup (windows / devcontainer) it won't auto-reload unless I have this configured.
This PR is a major refactor of the existing table infrastructure, moving from bootstrap-table to mantine datatable
Example:
Functionality
Notes