Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report template currency updates #4469

Merged
merged 3 commits into from
Mar 8, 2023
Merged

Report template currency updates #4469

merged 3 commits into from
Mar 8, 2023

Conversation

SchrodingersGat
Copy link
Member

@SchrodingersGat SchrodingersGat commented Mar 8, 2023 •
edited
Loading

Clean up support for rendering currency in external reports

  • Provide a currency tag in report.py
  • Add ability to convert to a target currency

@SchrodingersGat
Move render_currency into helpers.py
d5d7c99 
- Add duplicate tag to report.py
- Add option for currency conversion (optional)
@SchrodingersGat
Update report templates
bf5e6ec 
- Use "render_currency" instead of including price_data template
@SchrodingersGat
Remove 'price_data.html' template entirely
d1cc54e
@SchrodingersGat SchrodingersGat added the report Report/Label generation label Mar 8, 2023
@SchrodingersGat SchrodingersGat added this to the 0.11.0 milestone Mar 8, 2023
@SchrodingersGat SchrodingersGat mentioned this pull request Mar 8, 2023
Merged
@SchrodingersGat SchrodingersGat merged commit 3487582 into master Mar 8, 2023
@SchrodingersGat SchrodingersGat deleted the report-template-currency-updates branch March 8, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
report Report/Label generation
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
1 participant
@SchrodingersGat