-
-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dj-rest-auth #4187
Add dj-rest-auth #4187
Conversation
[FR] User registration via API Fixes inventree#3978
Does this work with existing SSO solutions? |
@SchrodingersGat that is still TODO |
…matmair/issue3978
…matmair/issue3978
…matmair/issue3978
…matmair/issue3978
@SchrodingersGat do we want to continue supporting all social connection options with #3901 or should we cut down the options for the first version? |
By "cut down" do you mean still supporting key ones (e.g. google / microsoft)? |
@SchrodingersGat it took a bit but it seems like we can maintain support for almost all providers (all that support OAuth2). Exceptions are (updated 2310 CEST):
I will work on adding support for Keycloak, OpenId and Twitter. Are you ok with waiting for FRs for the rest? |
Ok, I have to revise that; there is a Twitter OAuth2 and OIDC endpoint; I added keycloak so it should be good to go. |
Absolutely - I don't think it makes sense to spend a bunch of effort for integrations that may never actually be used. |
Does this replace our existing SSO login views completely? |
No, it just exposes them in another way. Under the hood the same functional code is used. |
Closes #3978 |
@matmair ready for merge? Does this need any additional docs? |
@SchrodingersGat I got it to a point where the settings do not need to change so no new docs needed. |
Well, great! Thanks :) |
This PR:
TODO:
Fixes #3978