Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove django-allauth-2fa #6281

Open
matmair opened this issue Jan 18, 2024 · 3 comments · May be fixed by #6293
Open

Remove django-allauth-2fa #6281

matmair opened this issue Jan 18, 2024 · 3 comments · May be fixed by #6293
Assignees
Labels
breaking Indicates a major update or change which breaks compatibility dependency Relates to a project dependency enhancement This is an suggested enhancement or new feature security Relates to a security issue
Milestone

Comments

@matmair
Copy link
Member

matmair commented Jan 18, 2024

We are currently using the awesome django-allauth-2fa. The upstream project django-allauth has added mfa recently and seems to support pretty much everything django-allauth does so IMO it is time to reduce the depency tree and remove django-allauth-2fa.

There are actually docs for this: https://docs.allauth.org/en/latest/mfa/django-allauth-2fa.html.
Although it should not really be breaking, I would still consider it as such as this is probably a one-way street.

@matmair matmair added enhancement This is an suggested enhancement or new feature dependency Relates to a project dependency security Relates to a security issue breaking Indicates a major update or change which breaks compatibility labels Jan 18, 2024
@matmair
Copy link
Member Author

matmair commented Jan 18, 2024

A few issues are linked to 2fa and it is probalby simpler to first do this and then tackle them: #6200, #6132

Also it seems that django-allauth could gain more factors so it is probably a safer bet long term:
pennersr/django-allauth#3550

@SchrodingersGat
Copy link
Member

I'm on board with this - makes sense to use a single library rather than maintaining two dependencies. I am also keen to address this soon so we can tackle the other outstanding issues

@matmair matmair self-assigned this Jan 19, 2024
@matmair matmair added this to the 0.14.0 milestone Jan 19, 2024
matmair added a commit to matmair/InvenTree that referenced this issue Jan 19, 2024
@matmair matmair modified the milestones: 0.14.0, 0.15.0 Feb 12, 2024
@matmair
Copy link
Member Author

matmair commented Feb 12, 2024

The release of 0.14.0 is nearing, moving to the next milestone

matmair added a commit to matmair/InvenTree that referenced this issue Mar 21, 2024
matmair added a commit to matmair/InvenTree that referenced this issue Apr 23, 2024
@matmair matmair modified the milestones: 0.15.0, 0.16.0 Apr 28, 2024
@matmair matmair modified the milestones: 0.16.0, 1.0.0 Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Indicates a major update or change which breaks compatibility dependency Relates to a project dependency enhancement This is an suggested enhancement or new feature security Relates to a security issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants