Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR/P-UI] New admin UI #5016

Closed
2 tasks done
matmair opened this issue Jun 11, 2023 · 10 comments
Closed
2 tasks done

[FR/P-UI] New admin UI #5016

matmair opened this issue Jun 11, 2023 · 10 comments
Assignees
Labels
api Relates to the API enhancement This is an suggested enhancement or new feature Platform UI Related to the React based User Interface
Milestone

Comments

@matmair
Copy link
Member

matmair commented Jun 11, 2023

Please verify that this feature request has NOT been suggested before.

  • I checked and didn't find a similar feature request

Problem statement

The current admin (global settings) UI is using HTML templates. This means you can not use all admin features headless and the UI needs to be fully rendered on the server side before being shown.

Suggested solution

Switch to new UI #5011

Describe alternatives you've considered

N/A

Examples of other systems

No response

Do you want to develop this?

  • I want to develop this.
@matmair matmair added enhancement This is an suggested enhancement or new feature user interface User interface api Relates to the API labels Jun 11, 2023
@matmair matmair added this to the 1.0.0 milestone Jun 11, 2023
@matmair matmair self-assigned this Jun 11, 2023
@matmair
Copy link
Member Author

matmair commented Jun 11, 2023

I will use this as a first PR to show the capabilities of the new UI.

@wolflu05
Copy link
Contributor

Good idea to start this, but I am not sure if the admin ui would be a good thing for the start. I just think we should build something users daily would use. The admin ui is something that gets not used very often. Or was that your thinking so that we can experiment with something that's not used so much?

@matmair
Copy link
Member Author

matmair commented Jun 11, 2023

@wolflu05 there is nearly nothing in the daily UI that does not require fast rewrites of the modal and forms interfaces - which is 20+ files.
The admin UI is pretty much standalone so the idea is to get fast results that can be discussed. And add the missing admin APIs.

@SchrodingersGat
Copy link
Member

@matmair do you mean the "django admin" page (which we use mostly out-of-the-box) or our "settings" page (which is user facing)?

@matmair
Copy link
Member Author

matmair commented Jun 12, 2023

@SchrodingersGat our settings page

@matmair
Copy link
Member Author

matmair commented Jun 15, 2023

Regarding this I ran into the first interesting question: do we define where settings go on the backend (ie making it pluggable and frontend version independent) or is that done in the frontend? Thoughts @inventree/triage?

@SchrodingersGat
Copy link
Member

SchrodingersGat commented Jun 15, 2023

By "where they go" do you mean the display
location? I think it is probably simpler to let the front-end define this, but you know more about the react/mantine setup...

@matmair
Copy link
Member Author

matmair commented Jun 15, 2023

I mean in terms of categories. Ie a category security with 3 settings, reporting with 20 settings etc. So a mapping where settings should be rendered. Because that is contingent on the server version.
The general URLs and layout will need to be done in react.

@SchrodingersGat
Copy link
Member

Oh right, yeah I think the categories have to be specified by the server and then rendered out by the front-end

@matmair matmair changed the title [FR] New admin UI [FR/P-UI] New admin UI Jul 18, 2023
@matmair matmair added Platform UI Related to the React based User Interface and removed user interface User interface labels Jul 20, 2023
matmair added a commit to matmair/InvenTree that referenced this issue Jul 23, 2023
@matmair matmair assigned SchrodingersGat and unassigned matmair Oct 10, 2023
@matmair
Copy link
Member Author

matmair commented Oct 30, 2023

Closed by #5679

@matmair matmair closed this as completed Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Relates to the API enhancement This is an suggested enhancement or new feature Platform UI Related to the React based User Interface
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants