Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jupyter: fixed previewer for jpynb #157

Merged
merged 2 commits into from
Jun 20, 2022

Conversation

alejandromumo
Copy link
Member

@alejandromumo alejandromumo commented Jun 17, 2022

Copy link
Member

@slint slint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one comment on the template selection.

Another concern is if we should bump the minimum version of nbconvert (from the current 6.0) to avoid hitting this issue, but it seems like the base template was also present in 6.0 (otherwise the min tests would fail I guess).

invenio_previewer/extensions/ipynb.py Show resolved Hide resolved
@luweizheng
Copy link

Hi @alejandromumo I have the same issue in invenio-rdm 9.1. Just want to know when to release the newer version of invenio-previewer? Now the latest v1.3.6 does not have this fix.

@alejandromumo
Copy link
Member Author

alejandromumo commented Aug 30, 2022

Hi @alejandromumo I have the same issue in invenio-rdm 9.1. Just want to know when to release the newer version of invenio-previewer? Now the latest v1.3.6 does not have this fix.

Hello there, I am sorry for the delay.
I created an issue to track this and we will try to release it as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

record details: file preview broken on jupyter notebooks
3 participants