WIP: Add dropdims(f, args..; dims, kwargs..) for reductions to drop dims
#4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickrobinson251
commented
Aug 31, 2019
nickrobinson251
commented
- attempt to address array reductions (sum, mean, etc.) and dropping dimensions JuliaLang/julia#16606
- (credit Matt Bauman and Stefan Karpinski for suggesting this approach)
This simple definition makes it easier to write reductions that drops the dimensions over which they reduce. Fixes JuliaLang#16606, addresses part of the root issue in JuliaLang#22000.
nickrobinson251
force-pushed
the
npr/mb/reductioneeze
branch
from
4d84d00
to
29945f3
Compare
nickrobinson251
commented
Aug 31, 2019
| @inferred(dropdims(sum, abs2, a, dims=(1,))) == | ||
| reshape(sum(a, dims=1), (1, 8, 8, 1))) | ||
| _sumplus(x; dims, plus) = sum(x; dims=dims) .+ plus # reduction with keywords | ||
| @test (@inferred(dropdims(_sumplus, a, dims=4, plus=1)) == |
There was a problem hiding this comment.
Couldn't think of / find a Base function that takes both dims and another keyword. Any suggestions?
(Of course, plenty of function outside Base do, e.g. Statistics.std takes dims and corrected keywords)
There was a problem hiding this comment.
sort(A::AbstractArray; dims, alg, lt, by, rev, order) in Base.Sort at sort.jl:972
But idk that it is one that you would use dropdims with
There was a problem hiding this comment.
thanks,! good find ... but yeah, agree - not sure that one will make the tests here nicer...
| ```jldoctest | ||
| julia> a = [3.0 2.0 6.0 8.0 | ||
| 6.0 1.0 4.0 2.0 | ||
| 3.0 0.0 7.0 6.0]; |
There was a problem hiding this comment.
Not sure on expected style here... just wanted something short and clear
Also, using Floats not Ints since Int is different on 32 and 64 bit systems
|
thanks for review -- moved to JuliaLang#33130 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.